Author yselivanov
Recipients asvetlov, giampaolo.rodola, ncoghlan, njs, yselivanov
Date 2018-01-29.06:20:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1517206802.68.0.467229070634.issue32703@psf.upfronthosting.co.za>
In-reply-to
Content
So the problem was that _PyGen_Finalize wasn't issuing any warnings if there's any error set in the current tstate.  And in Nathaniel's case, the current error was an AttributeError('__aexit__').

This check is weird, because right before raising the warning, we call PyErr_Fetch to temporarily reset the current exception if any, specifically to raise the warning :)

The PR just removes the check.  Unless I'm missing something this should fix the issue.
History
Date User Action Args
2018-01-29 06:20:02yselivanovsetrecipients: + yselivanov, ncoghlan, giampaolo.rodola, njs, asvetlov
2018-01-29 06:20:02yselivanovsetmessageid: <1517206802.68.0.467229070634.issue32703@psf.upfronthosting.co.za>
2018-01-29 06:20:02yselivanovlinkissue32703 messages
2018-01-29 06:20:02yselivanovcreate