Message310790
Tests
-----
I ran some of my own tests (not even close to all), they seem fine.
However, I could not find any tests for the added feature (safe
use with async) though. We would be adding a new feature without
tests.
Performance
-----------
I'm getting a large slowdown:
./python Modules/_decimal/tests/bench.py
bench.py
________
patched: [0.199, 0.206, 0.198, 0.199, 0.197, 0.202, 0.198, 0.201, 0.213, 0.199]
status-quo: [0.187, 0.184, 0.185, 0.183, 0.184, 0.188, 0.184, 0.183, 0.183, 0.185]
slowdown: > 10%
xwith.py
--------
patched: [0.535, 0.541, 0.523]
status-quo: [0.412, 0.393, 0.375]
slowdown: > 30%
Given the performance issues I'm -1 for adding the feature at
this point. |
|
Date |
User |
Action |
Args |
2018-01-26 20:36:19 | skrah | set | recipients:
+ skrah, gvanrossum, mark.dickinson, ned.deily, methane, yselivanov |
2018-01-26 20:36:19 | skrah | set | messageid: <1516998979.03.0.467229070634.issue32630@psf.upfronthosting.co.za> |
2018-01-26 20:36:19 | skrah | link | issue32630 messages |
2018-01-26 20:36:18 | skrah | create | |
|