Author inada.naoki
Recipients inada.naoki, serhiy.storchaka, vstinner, yselivanov
Date 2018-01-24.16:02:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
> * When dict size become 0, make the dict shared-empty, like dict.clear()

This will cause significant performance regression for `dict[a]=None; del dict[a]` loop.
del/pop shouldn't do clear().

> * When (dict size < dk_size/8), call insertion_resize()

This is bad too.
When ma_used=127 and dk_size=1024, new size will be 1024!
It's because current GROWTH_RATE is used*2 + size/2.

This GROWTH_RATE is set in issue17563.
We should understand it before changing anything.
Date User Action Args
2018-01-24 16:02:09inada.naokisetrecipients: + inada.naoki, vstinner, serhiy.storchaka, yselivanov
2018-01-24 16:02:09inada.naokisetmessageid: <>
2018-01-24 16:02:09inada.naokilinkissue32623 messages
2018-01-24 16:02:09inada.naokicreate