This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author berker.peksag
Recipients WildCard65, berker.peksag, martin.panter, paul.moore, steve.dower, terry.reedy, tim.golden, vstinner, zach.ware
Date 2018-01-04.20:14:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1515096887.49.0.467229070634.issue25095@psf.upfronthosting.co.za>
In-reply-to
Content
Thank you for tracking down the problem, William! I just took a quick look at your patch and it seems reasonable to me.

Setting protocol_version to 'HTTP/1.1' means setting the close_connection attribute of BaseHTTPRequestHandler to False which is expected and a feature of HTTP/1.1 (persistent connections)

Quoting RFC 2616:

    HTTP/1.1 defines the "close" connection option for the sender to
    signal that the connection will be closed after completion of the
    response.

    HTTP/1.1 applications that do not support persistent connections MUST
    include the "close" connection option in every message.

So I think it's OK to send a "Connection: close" header in the test (it would be nice to add a comment though)
History
Date User Action Args
2018-01-04 20:14:47berker.peksagsetrecipients: + berker.peksag, terry.reedy, paul.moore, vstinner, tim.golden, martin.panter, zach.ware, steve.dower, WildCard65
2018-01-04 20:14:47berker.peksagsetmessageid: <1515096887.49.0.467229070634.issue25095@psf.upfronthosting.co.za>
2018-01-04 20:14:47berker.peksaglinkissue25095 messages
2018-01-04 20:14:47berker.peksagcreate