Message309480
Thank you for tracking down the problem, William! I just took a quick look at your patch and it seems reasonable to me.
Setting protocol_version to 'HTTP/1.1' means setting the close_connection attribute of BaseHTTPRequestHandler to False which is expected and a feature of HTTP/1.1 (persistent connections)
Quoting RFC 2616:
HTTP/1.1 defines the "close" connection option for the sender to
signal that the connection will be closed after completion of the
response.
HTTP/1.1 applications that do not support persistent connections MUST
include the "close" connection option in every message.
So I think it's OK to send a "Connection: close" header in the test (it would be nice to add a comment though) |
|
Date |
User |
Action |
Args |
2018-01-04 20:14:47 | berker.peksag | set | recipients:
+ berker.peksag, terry.reedy, paul.moore, vstinner, tim.golden, martin.panter, zach.ware, steve.dower, WildCard65 |
2018-01-04 20:14:47 | berker.peksag | set | messageid: <1515096887.49.0.467229070634.issue25095@psf.upfronthosting.co.za> |
2018-01-04 20:14:47 | berker.peksag | link | issue25095 messages |
2018-01-04 20:14:47 | berker.peksag | create | |
|