This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jjolly
Recipients Thomas.Waldmann, alanmcintyre, jjolly, serhiy.storchaka, twouters
Date 2017-12-30.19:28:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1514662089.83.0.213398074469.issue28494@psf.upfronthosting.co.za>
In-reply-to
Content
Fix submitted that evaluates the ECD structure and validates the first CD entry. The fix also handles empty zipfiles.

IMO the purpose of this API is to *quickly* verify that the file is a valid zipfile. With this fix, the API only reads another 46 bytes of data (after a seek, of course). This should still qualify as "quick", especially after having potentially read 64k of data.

Perhaps a full zip validator would be appropriate in addition to is_zipfile. That would be more appropriate as a full feature rather than in this bugfix.
History
Date User Action Args
2017-12-30 19:28:09jjollysetrecipients: + jjolly, twouters, alanmcintyre, serhiy.storchaka, Thomas.Waldmann
2017-12-30 19:28:09jjollysetmessageid: <1514662089.83.0.213398074469.issue28494@psf.upfronthosting.co.za>
2017-12-30 19:28:09jjollylinkissue28494 messages
2017-12-30 19:28:09jjollycreate