Author nascheme
Recipients Demur Rumed, Mark.Shannon, benjamin.peterson, christian.heimes, mark.dickinson, nascheme, ncoghlan, pitrou, rhettinger, serhiy.storchaka, trent
Date 2017-12-29.18:08:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1514570933.04.0.213398074469.issue17611@psf.upfronthosting.co.za>
In-reply-to
Content
I apologize if my extra PR is causing confusion.  My original intention was to merely forward port Antoine changes so they could compile with the 'master' version of Python.  Over time I have made some fixes to it.  I have kept it open because I'm not sure which approach is better (JSR or duplication).

I did a quick test on the .pyc code size increase.  It is actually tiny for the Python code in Lib/.

PR 5006: 21259894 bytes
PR 4682: 21263081 bytes (+0.015%)

Running Serhiy's microbenchmarks:

for i in a:
    try: pass
    finally: pass

PR 4682: Mean +- std dev: 11.0 us +- 0.1 us
PR 5006: Mean +- std dev: 10.9 us +- 0.6 us


for i in a:
    try: continue
    finally: pass

PR 4682: Mean +- std dev: 9.46 us +- 0.85 us
PR 5006: Mean +- std dev: 14.3 us +- 0.3 us


for i in a:
    while True:
        try: break
        finally: pass

PR 4682: Mean +- std dev: 9.20 us +- 0.09 us
PR 5006: Mean +- std dev: 14.3 us +- 0.6 us
History
Date User Action Args
2017-12-29 18:08:53naschemesetrecipients: + nascheme, rhettinger, mark.dickinson, ncoghlan, pitrou, christian.heimes, benjamin.peterson, trent, Mark.Shannon, serhiy.storchaka, Demur Rumed
2017-12-29 18:08:53naschemesetmessageid: <1514570933.04.0.213398074469.issue17611@psf.upfronthosting.co.za>
2017-12-29 18:08:53naschemelinkissue17611 messages
2017-12-29 18:08:52naschemecreate