Author pitrou
Recipients Demur Rumed, Mark.Shannon, benjamin.peterson, christian.heimes, mark.dickinson, nascheme, ncoghlan, pitrou, rhettinger, serhiy.storchaka, trent
Date 2017-12-29.12:00:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <80b2fcb7-2cf7-bb0e-28be-7dbdb10b3917@free.fr>
In-reply-to <1514548130.42.0.213398074469.issue17611@psf.upfronthosting.co.za>
Content
Le 29/12/2017 à 12:48, Mark Shannon a écrit :
> 
> Why all these competing pull requests? It does feel like my original patch has been hijacked.

The original patch had a number of issues which needed to be fixed (in
addition to forward-port it to the latest git master), such as not
fixing some cases of stack consumption calculation.

> Also, before any more PRs, we need to decide whether to use subroutines or code duplication for finally blocks.
> 
> Here is my attempt at an objective comparison of the two approaches.
> 
>                        JSR style           Code duplication
> Speed                  Slower              Faster
> Interpreter            More complex        Simpler
> Bytecode generation    Simpler             More complex
> Bytecode size          ~ +0.1%             ~ +0.4%

Actually, when looking at your original patch
(https://bugs.python.org/review/17611/) vs. Serhiy's
https://github.com/python/cpython/pull/5006/, it looks like interpreter
complexity is the same.  Speed also seems to not be significantly
different.  So I would rephrase it as (compared to legacy bytecode
generation):

                      Subroutine              Code duplication
Speed                 Same                    Insignificantly faster
Interpreter           Simpler                 Simpler
Bytecode generation   Slightly more complex   Slightly more complex
Bytecode size         ~ +0.1%                 ~ +0.4%

That said, if you want to submit an updated version of the code
duplication approach (with the same amount of added tests and
debugging), we could compare on more equal grounds.
History
Date User Action Args
2017-12-29 12:00:08pitrousetrecipients: + pitrou, nascheme, rhettinger, mark.dickinson, ncoghlan, christian.heimes, benjamin.peterson, trent, Mark.Shannon, serhiy.storchaka, Demur Rumed
2017-12-29 12:00:08pitroulinkissue17611 messages
2017-12-29 12:00:08pitroucreate