Author v+python
Recipients martin.panter, mattpr, mdk, ned.deily, paul.moore, r.david.murray, rogerwang, ronaldoussoren, steve.dower, tim.golden, v+python, zach.ware
Date 2017-12-27.23:56:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1514418965.54.0.213398074469.issue31639@psf.upfronthosting.co.za>
In-reply-to
Content
I don't know how to look back at the previous version of the PR, I was barely able to find the "current version" each time. The following line is in the current version:

daemon_threads = True

Whether it was in the previous version, I don't know, but I didn't notice it, but maybe I overlooked it due to other changes in the same area, which are now gone. This line was not in the old suggestion that I had found and tried. When I added it, my test case started working. I have no idea what the line really does, but the HTTP server is a daemon, and we are adding threading, so it sounds appropriate.

I do wonder if it should somehow be put in the definition of ThreadedHTTPServer instead of "pass". And the old solution I had found had called the HTTPServer.__init__ which yours does not, which was surprising, but I'll not argue with success.
History
Date User Action Args
2017-12-27 23:56:05v+pythonsetrecipients: + v+python, paul.moore, ronaldoussoren, tim.golden, ned.deily, r.david.murray, martin.panter, zach.ware, steve.dower, mdk, mattpr, rogerwang
2017-12-27 23:56:05v+pythonsetmessageid: <1514418965.54.0.213398074469.issue31639@psf.upfronthosting.co.za>
2017-12-27 23:56:05v+pythonlinkissue31639 messages
2017-12-27 23:56:05v+pythoncreate