Author terry.reedy
Recipients cheryl.sabella, terry.reedy
Date 2017-12-25.03:57:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1514174277.84.0.213398074469.issue32411@psf.upfronthosting.co.za>
In-reply-to
Content
(f0, C0) is the correct insertion and line number order for the dict that would be returned by pyclbr for a fleshed-out file.  After 'sorted' is removed, the mock must imitate that.

One could argue that previously, and even now for 3.6, the initial insertion order should be 'wrong' to test that format_children sorts the return list.  But what is the chance that there will ever be an alternate 3.6 (or even later) implementation that runs tkinter and therefore might run IDLE but has a dict that does not preserve insert order?

I probably should not worry about the dict insert order guarantee being rescinded in a future version.  Maybe instead I should just add a comment that transform_children depends on iteration order being insert order == line-number order.
History
Date User Action Args
2017-12-25 03:57:57terry.reedysetrecipients: + terry.reedy, cheryl.sabella
2017-12-25 03:57:57terry.reedysetmessageid: <1514174277.84.0.213398074469.issue32411@psf.upfronthosting.co.za>
2017-12-25 03:57:57terry.reedylinkissue32411 messages
2017-12-25 03:57:56terry.reedycreate