Message308515
asyncio.Task now uses asyncio.iscoroutine() to give a comprehensible error if a user creates a Task for a non-awaitable type.
The problem is that iscoroutine() is quite expensive for non-native coroutines (like the ones compiled with Cython), as it uses `isinstance(obj, collections.abc.Coroutine)` call. This makes 'loop.create_task(cython_coroutine)' 20% slower than 'loop.create_task(python_coroutine)'.
The PR adds a positive type cache to the iscoroutine() function and to the asyncio.Task C implementation. Both caches make 'loop.create_task()' equally fast for all kinds of coroutines. |
|
Date |
User |
Action |
Args |
2017-12-18 05:33:40 | yselivanov | set | recipients:
+ yselivanov, asvetlov |
2017-12-18 05:33:40 | yselivanov | set | messageid: <1513575220.77.0.213398074469.issue32357@psf.upfronthosting.co.za> |
2017-12-18 05:33:40 | yselivanov | link | issue32357 messages |
2017-12-18 05:33:40 | yselivanov | create | |
|