Author pitrou
Recipients ezio.melotti, jonash, michael.foord, pitrou, rbcollins
Date 2017-11-20.23:32:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <04b4cfc7-0d73-debd-2555-1e266c086784@free.fr>
In-reply-to <1511220233.54.0.213398074469.issue32071@psf.upfronthosting.co.za>
Content
Le 21/11/2017 à 00:23, Jonas H. a écrit :
> 
> - The loader code really only deals with loading (i.e., finding + importing) tests. Yes it expects a file pattern like "test*.py" for identifying test case files. But apart from that it didn't "feel" right to put name based selection there.

Take a look at TestLoader.loadTestsFromName().  It does much more than
look up test files, it can also look up individual classes or methods.

> - In py.test you'll get a console output like "5 tests passed, 1 test failed, 12 tests deselected". We can't get anything similar without making bigger changes to the test loader, runner, etc. code. Using skip() we at least have some info on "skipped" tests, although they're technically not skipped.

I'm not sure what the point of displaying the number of "deselected"
tests is: that information doesn't sound very useful in itself.

But in any case, marking them skipped feels wrong to me.  Most often,
skipping a test is an indication that the current system is not fit to
run it (such as not enough RAM, or lacking a third-party library, or
being the wrong OS entirely).

> Are you still saying this should go to the test loader?

IMHO, yes.  Looking at your posted implementation, at least I don't
think TestSuite is the place for it.
History
Date User Action Args
2017-11-20 23:32:44pitrousetrecipients: + pitrou, rbcollins, ezio.melotti, michael.foord, jonash
2017-11-20 23:32:44pitroulinkissue32071 messages
2017-11-20 23:32:43pitroucreate