Author jonash
Recipients ezio.melotti, jonash, michael.foord, pitrou, rbcollins
Date 2017-11-20.23:23:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1511220233.54.0.213398074469.issue32071@psf.upfronthosting.co.za>
In-reply-to
Content
> > 3) Is the approach of dynamically wrapping 'skip()' around to-be-skipped test cases OK?

> I think this is the wrong approach.  A test that isn't selected shouldn't be skipped, it should not appear in the output at all.  Another reason for putting this in TestLoader :-)

My first implementation actually was mostly the test loader. Two things made me change my mind and try to make the changes in the suite code:

- The loader code really only deals with loading (i.e., finding + importing) tests. Yes it expects a file pattern like "test*.py" for identifying test case files. But apart from that it didn't "feel" right to put name based selection there.
- In py.test you'll get a console output like "5 tests passed, 1 test failed, 12 tests deselected". We can't get anything similar without making bigger changes to the test loader, runner, etc. code. Using skip() we at least have some info on "skipped" tests, although they're technically not skipped.

Are you still saying this should go to the test loader?
History
Date User Action Args
2017-11-20 23:23:53jonashsetrecipients: + jonash, pitrou, rbcollins, ezio.melotti, michael.foord
2017-11-20 23:23:53jonashsetmessageid: <1511220233.54.0.213398074469.issue32071@psf.upfronthosting.co.za>
2017-11-20 23:23:53jonashlinkissue32071 messages
2017-11-20 23:23:53jonashcreate