Author serhiy.storchaka
Recipients koobs, serhiy.storchaka
Date 2017-10-29.11:44:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1509277481.96.0.213398074469.issue31893@psf.upfronthosting.co.za>
In-reply-to
Content
In Modules/selectmodule.c it is assumed that the kevent structure is defined on FreeBSD and NetBSD as:

     struct kevent {
             uintptr_t ident;
             short     filter;
             u_short   flags;
             u_int     fflags;
             intptr_t  data;
             uintptr_t udata;
     };

and on OpenBSD as:

     struct kevent {
             u_int     ident;
             short     filter;
             u_short   flags;
             u_int     fflags;
             intptr_t  data;
             int       udata;
     };


Actually it is defined on FreeBSD as:

     struct kevent {
             uintptr_t ident;
             short     filter;
             u_short   flags;
             u_int     fflags;
             intptr_t  data;
             void      *udata;
     };

On OpenBSD as:

     struct kevent {
             uintptr_t ident;
             short     filter;
             u_short   flags;
             u_int     fflags;
             int64_t   data;
             void      *udata;
     };

And on NetBSD as:

     struct kevent {
             uintptr_t ident;
             uint32_t  filter;
             uint32_t  flags;
             uint32_t  fflags;
             int64_t   data;
             intptr_t  udata;
     };

Other issues are related to rich comparison. Due to integer overflows the ordering is not transitive. The rich comparison protocol is not properly supported, comparing a kevent_event object with a non-kevent_event object don't falls back to the rich comparison methods of the right arguments.
History
Date User Action Args
2017-10-29 11:44:42serhiy.storchakasetrecipients: + serhiy.storchaka, koobs
2017-10-29 11:44:41serhiy.storchakasetmessageid: <1509277481.96.0.213398074469.issue31893@psf.upfronthosting.co.za>
2017-10-29 11:44:41serhiy.storchakalinkissue31893 messages
2017-10-29 11:44:41serhiy.storchakacreate