Author serhiy.storchaka
Recipients enkore, josh.r, pitrou, serhiy.storchaka, xiang.zhang
Date 2017-10-25.16:25:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1508948702.56.0.213398074469.issue28564@psf.upfronthosting.co.za>
In-reply-to
Content
Following Antoine's suggestion the patch now makes shutil.rmtree() using os.scandir() on all platforms.

I doubt about one thing. This patch changes os.listdir passed to the onerror handler to os.scandir. This can break a user code that checks if the first argument in onerror is os.listdir. If keep this change, it should be documented in the "Porting to 3.7" section. Alternatively, we can continue passing os.listdir if os.scandir() failed despites the fact that os.listdir no longer used.
History
Date User Action Args
2017-10-25 16:25:02serhiy.storchakasetrecipients: + serhiy.storchaka, pitrou, josh.r, xiang.zhang, enkore
2017-10-25 16:25:02serhiy.storchakasetmessageid: <1508948702.56.0.213398074469.issue28564@psf.upfronthosting.co.za>
2017-10-25 16:25:02serhiy.storchakalinkissue28564 messages
2017-10-25 16:25:02serhiy.storchakacreate