Author vstinner
Recipients serhiy.storchaka, vstinner
Date 2017-10-24.09:19:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1508836742.89.0.213398074469.issue31827@psf.upfronthosting.co.za>
In-reply-to
Content
Copy of my comment on the PR: "So, I tried to remove the backward compatibility layer: I modified stat_result[ST_MTIME] to return float rather than int. Problem: it broke test_logging, the code deciding if a log file should be rotated or not.

While I'm not strongly opposed to modify stat_result[ST_MTIME], I prefer to do it in a separated PR. Moreover, we need maybe to emit a DeprecationWarning, or at least deprecate the feature in the doc, before changing the type, no?"

Serhiy's answer: "I agree, it should be done in a separate issue. It needs a special discussion. And maybe this can't be changed."
History
Date User Action Args
2017-10-24 09:19:02vstinnersetrecipients: + vstinner, serhiy.storchaka
2017-10-24 09:19:02vstinnersetmessageid: <1508836742.89.0.213398074469.issue31827@psf.upfronthosting.co.za>
2017-10-24 09:19:02vstinnerlinkissue31827 messages
2017-10-24 09:19:02vstinnercreate