Author mp5023
Recipients krivushinme, mp5023, rhettinger, serhiy.storchaka, vinay.sajip
Date 2017-10-12.13:39:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1507815558.9.0.213398074469.issue30767@psf.upfronthosting.co.za>
In-reply-to
Content
Additionally (probably should have separate PR) the _checkLevel was full of holes.
First, it's allowing any Integer which if you're claiming to "check" things is rather silly. At least bounds-check it to GE to NOTSET and LE to CRITICAL (or MAX or something handy in that regard).

Second, why is a string representation of an Integer a problem that needs to force the caller to fix his code? Same with lowercase of a recognized value. "Be liberal in what you accept" would seem to apply here. If it can be trivially reduced to an integer or upcased() to get a match then just do it, and send the corrected value back to the caller.
History
Date User Action Args
2017-10-12 13:39:18mp5023setrecipients: + mp5023, rhettinger, vinay.sajip, serhiy.storchaka, krivushinme
2017-10-12 13:39:18mp5023setmessageid: <1507815558.9.0.213398074469.issue30767@psf.upfronthosting.co.za>
2017-10-12 13:39:18mp5023linkissue30767 messages
2017-10-12 13:39:18mp5023create