Message304235
Additionally (probably should have separate PR) the _checkLevel was full of holes.
First, it's allowing any Integer which if you're claiming to "check" things is rather silly. At least bounds-check it to GE to NOTSET and LE to CRITICAL (or MAX or something handy in that regard).
Second, why is a string representation of an Integer a problem that needs to force the caller to fix his code? Same with lowercase of a recognized value. "Be liberal in what you accept" would seem to apply here. If it can be trivially reduced to an integer or upcased() to get a match then just do it, and send the corrected value back to the caller. |
|
Date |
User |
Action |
Args |
2017-10-12 13:39:18 | mp5023 | set | recipients:
+ mp5023, rhettinger, vinay.sajip, serhiy.storchaka, krivushinme |
2017-10-12 13:39:18 | mp5023 | set | messageid: <1507815558.9.0.213398074469.issue30767@psf.upfronthosting.co.za> |
2017-10-12 13:39:18 | mp5023 | link | issue30767 messages |
2017-10-12 13:39:18 | mp5023 | create | |
|