Message303277
> The code doesn't work nice with general objects supporting the buffer protocol. The length check suppose that the value has a length, and it is the size in bytes. The code for bytes_le suppose that the value supports slicing and concatenating results of the slicing. And all this code is made as fast as possible. Additional checks and conversions will slowdown it.
I enhanced my PR to also accept memoryview and bytearray in bytes_le. I don't think that performance matters so much here. First we need correctness, accept any bytes-like objects, no? |
|
Date |
User |
Action |
Args |
2017-09-28 20:21:18 | vstinner | set | recipients:
+ vstinner, barry, serhiy.storchaka, jnwatson |
2017-09-28 20:21:18 | vstinner | set | messageid: <1506630078.88.0.466225441844.issue29729@psf.upfronthosting.co.za> |
2017-09-28 20:21:18 | vstinner | link | issue29729 messages |
2017-09-28 20:21:18 | vstinner | create | |
|