This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author terry.reedy
Recipients terry.reedy
Date 2017-09-17.23:11:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1505689905.08.0.599656521868.issue31502@psf.upfronthosting.co.za>
In-reply-to
Content
The askyesno messagebox wrappers, added in #31287, returned None, which is interpreted as 'No', instead of the user entry.  With 'Yes' not seen, nothing was saved.

The manual tests, once the problem was understood, is to save a new theme/keyset and click the delete button twice, clicking No the first time and Yes the second time, and see what happens.

Unit testing the current version of askyesno would be difficult since it calls messagebox.askyesno(), which returns an answer, and there is no obvious way to get a reference to the actual widget, in order to generate simulated key or click events.

A long term solution might be to add a new subclass to query.Query, after reviewing *it* for ease of testing.
History
Date User Action Args
2017-09-17 23:11:45terry.reedysetrecipients: + terry.reedy
2017-09-17 23:11:45terry.reedysetmessageid: <1505689905.08.0.599656521868.issue31502@psf.upfronthosting.co.za>
2017-09-17 23:11:45terry.reedylinkissue31502 messages
2017-09-17 23:11:44terry.reedycreate