Author terry.reedy
Recipients terry.reedy
Date 2017-09-13.21:33:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1505338419.97.0.975370254214.issue31460@psf.upfronthosting.co.za>
In-reply-to
Content
The signature of browser.ClassBrowser(to be renamed ModuleBrowser).__init__ is

def __init__(self, flist, name, path, _htest=False, _utest=False)

flist is only used to access the application root.  Change it to master.  Then text can directly pass the test root.

name and path are the split apart pieces of the module path, minus '.py', which are promptly rejoined, with '.py'.  Callers always start valid path and have to split it and delete '.py' for the call.  Let them pass the full path.  A side-effect is that the browser will not work with a file without '.py'.

ModuleBrowser can them split off the filename and remove a '.p?' extension, if present.

The patch will have to change both .__init__ and callers, and ideally should somehow test that everything works.
History
Date User Action Args
2017-09-13 21:33:40terry.reedysetrecipients: + terry.reedy
2017-09-13 21:33:39terry.reedysetmessageid: <1505338419.97.0.975370254214.issue31460@psf.upfronthosting.co.za>
2017-09-13 21:33:39terry.reedylinkissue31460 messages
2017-09-13 21:33:39terry.reedycreate