Author eric.snow
Recipients Oren Milman, brett.cannon, eric.snow, ncoghlan, serhiy.storchaka
Date 2017-09-12.22:54:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1505256863.39.0.757066196573.issue31404@psf.upfronthosting.co.za>
In-reply-to
Content
> I haven't finished reviewing PR 1638. I'm not sure that this change
> is worth. It breaks a code that assumes that sys.module is a dict,
> and I afraid it slows down importing. Maybe revert this change until
> resolving all problems?

Yeah, I'm leaning that way myself.  I'll take another look later today or tomorrow.  FWIW, the likelihood of this causing problems to actual users is extremely low, so the urgency to fix this isn't high.  Still, I don't want this to linger.

As I said before, ideally we would prevent non-mappings from getting assigned to sys.modules.  One alternative would be to introduce sys.__modules__ and fall back to it if sys.modules is invalid.
History
Date User Action Args
2017-09-12 22:54:23eric.snowsetrecipients: + eric.snow, brett.cannon, ncoghlan, serhiy.storchaka, Oren Milman
2017-09-12 22:54:23eric.snowsetmessageid: <1505256863.39.0.757066196573.issue31404@psf.upfronthosting.co.za>
2017-09-12 22:54:23eric.snowlinkissue31404 messages
2017-09-12 22:54:23eric.snowcreate