Message301921
Generally, we consider the danger of introducing bugs to be more significant than the benefit of the "cleanup" changes. The fact that you are discussing further changes to the code in the PR make this more likely.
I haven't updated the PR with further code changes as suggested in the PR comments because the comments don't strictly relate to the changes put forward in this issue, and I don't want to go beyond the scope of the issue - the requested changes could go in a separate PR as needed.
The motivation is to use enumerate where it is a natural fit.
If you decide not to merge, then that is ok; let me know if I can help with anything. |
|
Date |
User |
Action |
Args |
2017-09-11 22:37:08 | Mark Byrne | set | recipients:
+ Mark Byrne, rhettinger, vstinner, r.david.murray, serhiy.storchaka |
2017-09-11 22:37:08 | Mark Byrne | set | messageid: <1505169428.59.0.474230101948.issue31417@psf.upfronthosting.co.za> |
2017-09-11 22:37:08 | Mark Byrne | link | issue31417 messages |
2017-09-11 22:37:08 | Mark Byrne | create | |
|