Author yselivanov
Recipients haypo, jimmylai, yselivanov
Date 2017-09-05.18:27:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1504636045.84.0.124321391247.issue31350@psf.upfronthosting.co.za>
In-reply-to
Content
> I'm not convinced that the PR is worth it. 3% is not interesting on a micro benchmark.

I found a small issue in the PR (left a comment in the PR).

I think using a tuple is still a good idea (even if the speedup is tiny) because logically, both attributes on that threading.local() object are always set and read at the same time.  Essentially, it's a pair of (loop, pid), so using a tuple here makes the code easier to reason about.
History
Date User Action Args
2017-09-05 18:27:25yselivanovsetrecipients: + yselivanov, haypo, jimmylai
2017-09-05 18:27:25yselivanovsetmessageid: <1504636045.84.0.124321391247.issue31350@psf.upfronthosting.co.za>
2017-09-05 18:27:25yselivanovlinkissue31350 messages
2017-09-05 18:27:25yselivanovcreate