Author rhettinger
Recipients berker.peksag, gvx, rhettinger
Date 2017-09-01.16:19:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1504282783.71.0.412214556777.issue31325@psf.upfronthosting.co.za>
In-reply-to
Content
* The named tuple class should begin with a capital letter and be fully self-documenting: "RequestRate".

* The creation of the named tuple class should be done only once, not on every call.  Instead only a new instance should be creating on every call:

     entry.req_rate = req_rate(RequestRate)

* There needs to be a test.

* The docstring should be updated to include the name of the class refer to the term named tuple instead of the namedtuple() factory function:

     - Returns the contents of the ``Request-rate`` parameter from
     - ``robots.txt`` in the form of a :func:`~collections.namedtuple`
     - ``(requests, seconds)``.  If there is no such parameter or it doesn't

     + Returns the contents of the ``Request-rate`` parameter from
     + ``robots.txt`` as a :term:`named tuple` ``RequestRate(requests, seconds)``.
     + If there is no such parameter or it doesn't
History
Date User Action Args
2017-09-01 16:19:43rhettingersetrecipients: + rhettinger, berker.peksag, gvx
2017-09-01 16:19:43rhettingersetmessageid: <1504282783.71.0.412214556777.issue31325@psf.upfronthosting.co.za>
2017-09-01 16:19:43rhettingerlinkissue31325 messages
2017-09-01 16:19:43rhettingercreate