Author terry.reedy
Recipients terry.reedy
Date 2017-08-27.19:24:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1503861877.04.0.798674063442.issue31287@psf.upfronthosting.co.za>
In-reply-to
Content
test_configdialog twice patches tkinter.messagebox to mock askyesno without restoring it properly.  As a consequence, the outwin test in #30617 failed because the messagebox module in editor lacked askyesno.

First patch: fix configdialog and test_configdialog.  Similar to what is done elsewhere, make askyesno an instance method so that it is masked by an instance attribute mock and unmasked by deleting the instance function.  In the process, revise the messabebox import,

Follow-on patch(es): check exiting tests and apply the same idea everywhere.  In the process, end use of 'tkMessageBox'.
History
Date User Action Args
2017-08-27 19:24:37terry.reedysetrecipients: + terry.reedy
2017-08-27 19:24:37terry.reedysetmessageid: <1503861877.04.0.798674063442.issue31287@psf.upfronthosting.co.za>
2017-08-27 19:24:36terry.reedylinkissue31287 messages
2017-08-27 19:24:36terry.reedycreate