Message300590
Oren,
1) I might be completely wrong, but, personally, I think about OverflowError vs ValueError difference like this: if the value couldn't be handled because method's logic cannot handle it - it's a ValueError; if it could not be handled because of a low-level platform-dependent limitation - it's an OverflowError. Before that PR, the _length_ maximum value was hard-coded in the method itself, thus one might say that it was "a part of logic". With this PR, you just need a system with a large enough size_t.
(May be, after a thousand years, it would even handle 2**1000. But negative values would be still logically incorrect. Thus, I'm only talking about "too large" case.)
2) It would be much more difficult to run into this limitation in a daily practice (e.g. by passing a very long string). |
|
Date |
User |
Action |
Args |
2017-08-19 23:17:48 | i3v | set | recipients:
+ i3v, amaury.forgeotdarc, belopolsky, meador.inge, serhiy.storchaka, Oren Milman |
2017-08-19 23:17:48 | i3v | set | messageid: <1503184668.46.0.973928438111.issue29843@psf.upfronthosting.co.za> |
2017-08-19 23:17:48 | i3v | link | issue29843 messages |
2017-08-19 23:17:48 | i3v | create | |
|