Author terry.reedy
Recipients csabella, terry.reedy
Date 2017-07-30.05:53:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1501394037.49.0.0300559035775.issue31050@psf.upfronthosting.co.za>
In-reply-to
Content
Now that we know what we are doing, we can simplify the steps.  These assume that #21004, PR2905, which prepares create_widgets and fixes the GeneralTest that was broken by Notebook, has been merged.

For configdialog:
* copy general block after FontPage;
* add 'class GenPage(Frame):' and def __init__ modeled on FontPage.__init__, but no highlight parameter;
* replace 'frame = dialog.tabpages...' at top of create_page_general with 'frame = self';
* comment out old code;
* in create_widgets change 'self.create_page_general' to 'GenPage(note)'.

For test_configdialog:
* change 'GeneralTest' to 'GenPageTest
* change setUpClass similarly as in FontPageTest;
* change test functions similarly as in FontPageTest and otherwise as needed to keep tests passing.
History
Date User Action Args
2017-07-30 05:53:57terry.reedysetrecipients: + terry.reedy, csabella
2017-07-30 05:53:57terry.reedysetmessageid: <1501394037.49.0.0300559035775.issue31050@psf.upfronthosting.co.za>
2017-07-30 05:53:57terry.reedylinkissue31050 messages
2017-07-30 05:53:57terry.reedycreate