Author csabella
Recipients csabella, terry.reedy
Date 2017-07-30.00:15:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1501373729.69.0.207712746424.issue31004@psf.upfronthosting.co.za>
In-reply-to
Content
I'm pushing step 2 with an error in the test.  It's on the keydown in test_fontlist_key.  I just didn't want to hold you up from looking at the rest of it because of one test.

I did run into a bunch of other issues/questions while doing this.  I didn't add tracers.attach() to the FontPage class.  So, I had to call it in the FontPageTest.  Well, I then also added a detach so it wouldn't carry to the other tests and of course all the other tests broke.  So, I added setup/teardown of tracers in all the test classes.  I don't know if that was the right way to go or if adding tracers.attach to FontPage and then just leaving everything attached would be ok.

Also, I tried to minimize the change from `d=dialog` to `d = self.page`, so I kept the name `d`.

Adding set_samples to load_font_cfg upped the called count to 4 in test_load_font_cfg because the tracers are attached when it's called.  I think you mentioned that test needs to be changed with them detached, but I wasn't sure if you wanted that changed now or later.

In FontPage, I tried not to change code yet, so I keep the name `parent` even though `note` will be passed in.
History
Date User Action Args
2017-07-30 00:15:30csabellasetrecipients: + csabella, terry.reedy
2017-07-30 00:15:29csabellasetmessageid: <1501373729.69.0.207712746424.issue31004@psf.upfronthosting.co.za>
2017-07-30 00:15:29csabellalinkissue31004 messages
2017-07-30 00:15:27csabellacreate