Message299162
There's an alternative fix which follows a similar approach to the one you mention: https://github.com/python/cpython/pull/2707/.
I personally don't like too much to reuse again again an old variable as it's true that we don't know how people are using it (although I take they use it as a boolean since it's assigned to False).
On the other side this approach copies the map when it's not strictly necessary to do use just because we can't do it the proper way by using closing, as shown in the PR using it: https://github.com/python/cpython/pull/2764/files |
|
Date |
User |
Action |
Args |
2017-07-25 23:08:20 | walkhour | set | recipients:
+ walkhour, vstinner, giampaolo.rodola, Nir Soffer |
2017-07-25 23:08:20 | walkhour | set | messageid: <1501024100.02.0.343256080334.issue30931@psf.upfronthosting.co.za> |
2017-07-25 23:08:20 | walkhour | link | issue30931 messages |
2017-07-25 23:08:19 | walkhour | create | |
|