Message298692
I don't think most of the changes improve readability of json.tool. Everyone has their own preferences and it's usually not enough to justify code churn.
Also, we don't need to add comments when the code itself is pretty descriptive:
# Output JSON
with options.outfile as outfile:
json.dump(obj, outfile, sort_keys=options.sort_keys, indent=4)
outfile.write('\n')
IMO, the only acceptable change is the correct use of 'default' parameter for 'infile' and 'outfile'. |
|
Date |
User |
Action |
Args |
2017-07-19 22:21:50 | berker.peksag | set | recipients:
+ berker.peksag, r.david.murray, dhimmel |
2017-07-19 22:21:50 | berker.peksag | set | messageid: <1500502910.02.0.924443250077.issue30971@psf.upfronthosting.co.za> |
2017-07-19 22:21:49 | berker.peksag | link | issue30971 messages |
2017-07-19 22:21:49 | berker.peksag | create | |
|