Author odd_bloke
Recipients odd_bloke
Date 2017-07-17.14:36:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1500302203.03.0.925103147939.issue30949@psf.upfronthosting.co.za>
In-reply-to
Content
The convenience assertion methods on mock objects can be easily mistyped and if they are mistyped, they will silently pass.  This can be quite user-hostile.  Consider the following:

>>> example = Mock()
>>> example.assert_called_once()
>>> example.assert_caled_once_with(...)

This will not raise any exceptions, though the first feels natural and the latter is misspelt.  To avoid using the methods, one can type:

>>> example = Mock()
>>> assert example.call_count == 1
>>> assert example.call_args_list == [call(...)]

but the meaning of that latter statement is particularly non-obvious.  Instead, it would be great if I could import the assertions from mock as functions, and call them with mock as the first argument:

>>> from unittest.mock import assert_called_once  # This will be an ImportError
>>> example = Mock()
>>> assert_caled_once_with(example, ...)  # A NameError
>>> assert_called_once_with(example, ...)  # Great success!
History
Date User Action Args
2017-07-17 14:36:43odd_blokesetrecipients: + odd_bloke
2017-07-17 14:36:43odd_blokesetmessageid: <1500302203.03.0.925103147939.issue30949@psf.upfronthosting.co.za>
2017-07-17 14:36:42odd_blokelinkissue30949 messages
2017-07-17 14:36:42odd_blokecreate