Message297444
Serhiy: "The C code looks cumbersome. It could be made a little simpler if accumulate arguments into a string rather than a list."
Utkarsh's first version used C code. I proposed to use a PyList and PyUnicodeObject strings to not have to compute the size of the char[] buffers.
The annoying part is to handle the ", " separator. I also had bad experiences with handling char* strings. It's so easy to make mistakes :-(
IMHO the current C code using Python objects is not that complex, but I don't really care of the implementation as soon as it works :-) |
|
Date |
User |
Action |
Args |
2017-06-30 20:59:31 | vstinner | set | recipients:
+ vstinner, belopolsky, r.david.murray, martin.panter, serhiy.storchaka, musically_ut |
2017-06-30 20:59:31 | vstinner | set | messageid: <1498856371.62.0.314934273021.issue30302@psf.upfronthosting.co.za> |
2017-06-30 20:59:31 | vstinner | link | issue30302 messages |
2017-06-30 20:59:31 | vstinner | create | |
|