Message297429
@r.david.murray: I'm primarily waiting for Serhiy (and, optionally Martin) to "Okay" the pull request.
The code seems fine (@haypo has had a through look at it), but we still were mildly divided over whether we want to factor out the negative sign or not.
re: thoughts and opinions; I wanted to have them on:
- Whether to factor out the negative sign.
- Whether to throw in the doc-string/documentation changes into this PR or in a new one.
Current position on these questions:
- In favor of factoring out the -ve sign: Martin
Not in favor of factoring out the -ve sign: Victor, R. David
- DocString changes: (@haypo's opinion) in a separate PR.
~
ut |
|
Date |
User |
Action |
Args |
2017-06-30 16:32:50 | musically_ut | set | recipients:
+ musically_ut, belopolsky, vstinner, r.david.murray, martin.panter, serhiy.storchaka |
2017-06-30 16:32:50 | musically_ut | set | messageid: <1498840370.13.0.774390808385.issue30302@psf.upfronthosting.co.za> |
2017-06-30 16:32:50 | musically_ut | link | issue30302 messages |
2017-06-30 16:32:49 | musically_ut | create | |
|