Author musically_ut
Recipients belopolsky, haypo, martin.panter, musically_ut, r.david.murray, serhiy.storchaka
Date 2017-06-30.16:32:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1498840370.13.0.774390808385.issue30302@psf.upfronthosting.co.za>
In-reply-to
Content
@r.david.murray: I'm primarily waiting for Serhiy (and, optionally Martin) to "Okay" the pull request. 

The code seems fine (@haypo has had a through look at it), but we still were mildly divided over whether we want to factor out the negative sign or not.

re: thoughts and opinions; I wanted to have them on:

  - Whether to factor out the negative sign.
  - Whether to throw in the doc-string/documentation changes into this PR or in a new one.


Current position on these questions:

- In favor of factoring out the -ve sign: Martin
  Not in favor of factoring out the -ve sign: Victor, R. David


- DocString changes: (@haypo's opinion) in a separate PR.


~
ut
History
Date User Action Args
2017-06-30 16:32:50musically_utsetrecipients: + musically_ut, belopolsky, haypo, r.david.murray, martin.panter, serhiy.storchaka
2017-06-30 16:32:50musically_utsetmessageid: <1498840370.13.0.774390808385.issue30302@psf.upfronthosting.co.za>
2017-06-30 16:32:50musically_utlinkissue30302 messages
2017-06-30 16:32:49musically_utcreate