Author terry.reedy
Recipients CaribbeanCruise, amaury.forgeotdarc, gpolo, roger.serwy, terry.reedy
Date 2017-06-22.19:47:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1498160864.99.0.480041649742.issue6739@psf.upfronthosting.co.za>
In-reply-to
Content
Patch mostly looks good.  To apply now, keybindingDialog.py must become config_key.py.  I have no idea what other merge issues there might be.  The name of the new function'KeySequenceCheck()' should be 'sequence_ok()'.  A minimal new test should call sequence_ok with invalid sequence '<Control-Shift>' and valid sequence '<Control-Shift-Key-x>'.
History
Date User Action Args
2017-06-22 19:47:45terry.reedysetrecipients: + terry.reedy, amaury.forgeotdarc, gpolo, roger.serwy, CaribbeanCruise
2017-06-22 19:47:44terry.reedysetmessageid: <1498160864.99.0.480041649742.issue6739@psf.upfronthosting.co.za>
2017-06-22 19:47:44terry.reedylinkissue6739 messages
2017-06-22 19:47:44terry.reedycreate