This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients christian.heimes, jkloth, paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Date 2017-06-20.22:07:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1497996460.76.0.0186424822613.issue30368@psf.upfronthosting.co.za>
In-reply-to
Content
So, I made final tests with the merged commit. I manually uninstalled (Active)Perl. Without the commit, the compilation of ssl failed on my Windows VM since I'm using VS 2008.

(1) using build.bat

git clean -fdx
In the VS2008 shell, type: PC\VS9.0\build.bat -e -d -p x64
=> you get a python_d.exe with a working _ssl module!

(2) using VS GUI

git clean -fdx
PCbuild\get_externals.bat
Open VS 2008, build the project
=> compilation of _ssl fails with a permission error about a temporay object file... I don't understand it
Rebuild the project
=> compilation of _ssl works, python_d.exe has a working _ssl module!

Except of the "temporary" (but reproductible) compilation error in the VS GUI, I confirm that the change fixes this issue!

I prefer to keep the issue open until the buildbot is repaired (expat issue).
History
Date User Action Args
2017-06-20 22:07:40vstinnersetrecipients: + vstinner, paul.moore, christian.heimes, tim.golden, jkloth, zach.ware, steve.dower
2017-06-20 22:07:40vstinnersetmessageid: <1497996460.76.0.0186424822613.issue30368@psf.upfronthosting.co.za>
2017-06-20 22:07:40vstinnerlinkissue30368 messages
2017-06-20 22:07:40vstinnercreate