Author terry.reedy
Recipients cheryl.sabella, terry.reedy
Date 2017-06-19.19:30:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1497900640.78.0.881819948892.issue30495@psf.upfronthosting.co.za>
In-reply-to
Content
You were waiting on my review of the revised patch.

1. Remove the help_about changes.  Reworking help_about is #24813.  I just reviewed Mark Roseman's patch.  I do not want the button frames because I would like to get rid of the buttons.  Besides that, I don't think the classes give enough benefit.  If I wanted to keep the buttons, create_py/idle/button functions might be considered.  You can attach to that issue a minimal change patch or PR that splits off AboutFrame from AboutDialog (the window).  Leave the latter name alone for now to minimize changes needed in other files.  We can then consider adding pieces of what Mark did one at a time.

2. I downloaded the patch, deleted help_about changes, applied, and tested.

Test_help_about needs two  insertions of '.textframe'  to solve
======================================================================
ERROR: test_file_buttons (idlelib.idle_test.test_help_about.LiveDialogTest)
Test buttons that display files.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "f:\dev\3x\lib\idlelib\idle_test\test_help_about.py", line 67, in test_file_buttons
    dialog._current_textview.text.get('1.0', '1.end'))
AttributeError: 'TextviewWindow' object has no attribute 'text'

======================================================================
ERROR: test_printer_buttons (idlelib.idle_test.test_help_about.LiveDialogTest)
Test buttons whose commands use printer function.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "f:\dev\3x\lib\idlelib\idle_test\test_help_about.py", line 48, in test_printer_buttons
    dialog._current_textview.text.get('1.0', '1.end'))
AttributeError: 'TextviewWindow' object has no attribute 'text'

Make a PR this time so I can review a side-by-side diff and retest.
History
Date User Action Args
2017-06-19 19:30:40terry.reedysetrecipients: + terry.reedy, cheryl.sabella
2017-06-19 19:30:40terry.reedysetmessageid: <1497900640.78.0.881819948892.issue30495@psf.upfronthosting.co.za>
2017-06-19 19:30:40terry.reedylinkissue30495 messages
2017-06-19 19:30:40terry.reedycreate