Author terry.reedy
Recipients terry.reedy
Date 2017-06-14.18:15:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1497464140.48.0.517260109183.issue30666@psf.upfronthosting.co.za>
In-reply-to
Content
1. Test_autocomplete.AutoCompleteTest has a test_method for each method of autocomplete.AutoComplete.  The last 5 test methods are empty ('pass'). Finish them.  A couple of the methods might be usefully split into smaller methods.  Get_entity is actually a function, as 'self' is ignored. After the first else, fetch_completions is also independent of 'self'.  PR 2011 combines the two blocks into a function that can be moved to run.py.

These method tests should be supplemented by user action tests with live widgets and simulated key events.  Such tests would be black box tests in that they should be independent of the implementation.

2. AutoCompleteWindow, in autocomplete_w, is untested.  It was the locus of the bug in #15786.  To get the fix into 3.6.2, it was merged after hand-testing, without adding automated tests.  They need to be added before further patching.

Some of the methods of ACW seem hard to test as they are long and hard to describe succinctly.  Perhaps black-box user tests should be emphasized for this class.
History
Date User Action Args
2017-06-14 18:15:40terry.reedysetrecipients: + terry.reedy
2017-06-14 18:15:40terry.reedysetmessageid: <1497464140.48.0.517260109183.issue30666@psf.upfronthosting.co.za>
2017-06-14 18:15:40terry.reedylinkissue30666 messages
2017-06-14 18:15:40terry.reedycreate