Author grzgrzgrz3
Recipients davin, grzgrzgrz3, paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Date 2017-06-09.12:53:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1497012791.92.0.263244462557.issue30595@psf.upfronthosting.co.za>
In-reply-to
Content
Looks like build bot is too slow for timeout=0.1. 

I am guessing `0.1` is too low because we have wrong condition in Queue.get.

It should be.

diff --git a/Lib/multiprocessing/queues.py b/Lib/multiprocessing/queues.py
index dda03dd..42e9884 100644
--- a/Lib/multiprocessing/queues.py
+++ b/Lib/multiprocessing/queues.py
@@ -101,7 +101,7 @@ class Queue(object):
             try:
                 if block:
                     timeout = deadline - time.time()
-                    if timeout < 0 or not self._poll(timeout):
+                    if self._poll(timeout):
                         raise Empty
                 elif not self._poll():
                     raise Empty

If we successfully acquired self._rlock, we should poll no matter how long acquire took.
History
Date User Action Args
2017-06-09 12:53:11grzgrzgrz3setrecipients: + grzgrzgrz3, paul.moore, vstinner, tim.golden, zach.ware, steve.dower, davin
2017-06-09 12:53:11grzgrzgrz3setmessageid: <1497012791.92.0.263244462557.issue30595@psf.upfronthosting.co.za>
2017-06-09 12:53:11grzgrzgrz3linkissue30595 messages
2017-06-09 12:53:11grzgrzgrz3create