Author rhettinger
Recipients MSeifert, Will Roberts, mark.dickinson, rhettinger, serhiy.storchaka, smarnach
Date 2017-06-08.06:41:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1496904064.01.0.612985547874.issue30537@psf.upfronthosting.co.za>
In-reply-to
Content
Applied patch.  In theory, this was reasonable.  Since islice() deals with indices, checking __index__ seems reasonable.

On the other hand, stable high-performance code was changed without any known reasonable use cases, and no one will ever likely see a benefit. A cheap atomic operation was replaced with a more complex and less thread-safe chain of calls (I'm no longer even sure that the test cases cover all the possible code paths).

Users might be better off by not seeing an unhelpful error message when passing in a numpy.int32, or they might be worse-off by having lost a cue that they were writing inefficient code (which invisibly creates temporary integer objects on every call when presumably the whole reason for using numpy was a concern for efficiency).
History
Date User Action Args
2017-06-08 06:41:04rhettingersetrecipients: + rhettinger, mark.dickinson, smarnach, serhiy.storchaka, MSeifert, Will Roberts
2017-06-08 06:41:04rhettingersetmessageid: <1496904064.01.0.612985547874.issue30537@psf.upfronthosting.co.za>
2017-06-08 06:41:03rhettingerlinkissue30537 messages
2017-06-08 06:41:03rhettingercreate