Author vstinner
Recipients eric.snow, eryksun, matrixise, paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Date 2017-06-07.09:16:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1496826993.78.0.738398646692.issue30547@psf.upfronthosting.co.za>
In-reply-to
Content
> At the end, you should get the commit 6b4be195cd8868b76eb6fbe166acc39beee8ce36.

The commit is a giant change. So let me help you, the following change is strange. value is replaced whereas its value is non-NULL... Maybe it's the regression? ;-)

diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
index 90f8551..03601ea 100644
--- a/Python/pylifecycle.c
+++ b/Python/pylifecycle.c
@@ -291,6 +291,9 @@ import_init(PyInterpreterState *interp, PyObject *sysmod)
 
     /* Install importlib as the implementation of import */
     value = PyObject_CallMethod(importlib, "_install", "OO", sysmod, impmod);
+    if (value != NULL)
+        value = PyObject_CallMethod(importlib,
+                                    "_install_external_importers", "");
     if (value == NULL) {
         PyErr_Print();
         Py_FatalError("Py_Initialize: importlib install failed");


St├ęphane Wirtel (matrixise): "this issue can be executed on Linux, I think I am going to work on this one."

Would you like to work on a patch?
History
Date User Action Args
2017-06-07 09:16:33vstinnersetrecipients: + vstinner, paul.moore, tim.golden, eric.snow, zach.ware, eryksun, steve.dower, matrixise
2017-06-07 09:16:33vstinnersetmessageid: <1496826993.78.0.738398646692.issue30547@psf.upfronthosting.co.za>
2017-06-07 09:16:33vstinnerlinkissue30547 messages
2017-06-07 09:16:33vstinnercreate