Author steve.dower
Recipients paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Date 2017-06-02.21:09:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1496437770.9.0.75244624328.issue30557@psf.upfronthosting.co.za>
In-reply-to
Content
faulthandler adds a structured exception handler on Windows so we can dump a Python traceback before crashing. This should only be done for fatal exceptions, but is currently done for some non-fatal exceptions.

The current test is `flags & EXCEPTION_NONCONTINUABLE`, which is incorrect (as evidenced by the fact that the check is wrong in its current context and should be `!(flags & EXCEPTION_NONCONTINUABLE)`).

Instead, `code & 0x80000000` determines whether the exception is an error. If not, we should skip logging any info.
History
Date User Action Args
2017-06-02 21:09:30steve.dowersetrecipients: + steve.dower, paul.moore, vstinner, tim.golden, zach.ware
2017-06-02 21:09:30steve.dowersetmessageid: <1496437770.9.0.75244624328.issue30557@psf.upfronthosting.co.za>
2017-06-02 21:09:30steve.dowerlinkissue30557 messages
2017-06-02 21:09:30steve.dowercreate