Author serhiy.storchaka
Recipients pitrou, serhiy.storchaka, vinay.sajip
Date 2017-06-01.09:28:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1496309297.87.0.0618746640986.issue30520@psf.upfronthosting.co.za>
In-reply-to
Content
The idea LGTM. But we should first check that the logger is accessible by the name: getLogger(self.name) is self. The same is done when pickling classes, functions, etc. It shouldn't be a surprise on unpickler side.

And maybe use not getLogger(), but different method which should fail if the logger doesn't exist rather than creating it. Otherwise this looks as pickling open files by name.
History
Date User Action Args
2017-06-01 09:28:17serhiy.storchakasetrecipients: + serhiy.storchaka, vinay.sajip, pitrou
2017-06-01 09:28:17serhiy.storchakasetmessageid: <1496309297.87.0.0618746640986.issue30520@psf.upfronthosting.co.za>
2017-06-01 09:28:17serhiy.storchakalinkissue30520 messages
2017-06-01 09:28:17serhiy.storchakacreate