Author osantana
Recipients Danilo Shiga, Jelle Zijlstra, mark.dickinson, martin.panter, osantana, pitrou, serhiy.storchaka
Date 2017-05-25.17:08:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1495732104.51.0.766827219967.issue30441@psf.upfronthosting.co.za>
In-reply-to
Content
New version of patch:

1. Use RLock instead of Lock (Mark & Antoine recomendation)
2. Add lock acquire at `__setitem__` and `__delitem__` as following (Mark & Antoine recomendation)
3. Add lock protection in `__repr__` implementation.

I've some questions pending:

1. Is it a good idea to wrap self._data access with lock in __getitem__? (I suspect it's not)
2. Is it a good idea to lock protect self.copy() and self.setdefault() (I suspect it's not because both uses __iter__ that is already protected)
History
Date User Action Args
2017-05-25 17:08:24osantanasetrecipients: + osantana, mark.dickinson, pitrou, martin.panter, serhiy.storchaka, Jelle Zijlstra, Danilo Shiga
2017-05-25 17:08:24osantanasetmessageid: <1495732104.51.0.766827219967.issue30441@psf.upfronthosting.co.za>
2017-05-25 17:08:24osantanalinkissue30441 messages
2017-05-25 17:08:24osantanacreate