Message294498
New version of patch:
1. Use RLock instead of Lock (Mark & Antoine recomendation)
2. Add lock acquire at `__setitem__` and `__delitem__` as following (Mark & Antoine recomendation)
3. Add lock protection in `__repr__` implementation.
I've some questions pending:
1. Is it a good idea to wrap self._data access with lock in __getitem__? (I suspect it's not)
2. Is it a good idea to lock protect self.copy() and self.setdefault() (I suspect it's not because both uses __iter__ that is already protected) |
|
Date |
User |
Action |
Args |
2017-05-25 17:08:24 | osantana | set | recipients:
+ osantana, mark.dickinson, pitrou, martin.panter, serhiy.storchaka, JelleZijlstra, Danilo Shiga |
2017-05-25 17:08:24 | osantana | set | messageid: <1495732104.51.0.766827219967.issue30441@psf.upfronthosting.co.za> |
2017-05-25 17:08:24 | osantana | link | issue30441 messages |
2017-05-25 17:08:24 | osantana | create | |
|