➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gregory.p.smith
Recipients Florian Hassanen, Marcus.Smith, Oleg N, Sébastien Taylor, benjamin.peterson, dstufft, fourplusone, gregory.p.smith, kirk.d.sayre, ncoghlan, paul.moore, ppinard
Date 2017-05-21.18:03:21
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1495389801.65.0.957989939296.issue24960@psf.upfronthosting.co.za>
In-reply-to
Content 
re: Paul's "I'm not sure I see why you'd want to run lib2to3 with the embedded distribution anyway. Surely you'd do any 2to3 conversion in a normal development installation"

lib2to3 is a library useful for doing things with Python code.  Not just a stand alone tool.

Kirk: Could you please post your change as a pull request on https://github.com/python/cpython/ rather than attaching individual files here.  a full file isn't a reviewable change.

Also, Grammar.txt is loaded and saved as a cached pickle file for speed.  When packaging up an embedded stdlib bundle I recommend shipping that pickle.  (loaded in pgen2/grammar.py).

both probably need to use https://docs.python.org/3.6/library/pkgutil.html#pkgutil.get_data to read the file out of the package rather than assuming it lives on a filesystem.

using the zipfile module within lib2to3 to try and figure out when it should look somewhere other than a filesystem is the wrong approach.
History
Date User Action Args
2017-05-21 18:03:21gregory.p.smithsetrecipients: + gregory.p.smith, paul.moore, ncoghlan, benjamin.peterson, dstufft, Marcus.Smith, Oleg N, Florian Hassanen, fourplusone, Sébastien Taylor, ppinard, kirk.d.sayre
2017-05-21 18:03:21gregory.p.smithsetmessageid: <1495389801.65.0.957989939296.issue24960@psf.upfronthosting.co.za>
2017-05-21 18:03:21gregory.p.smithlinkissue24960 messages
2017-05-21 18:03:21gregory.p.smithcreate