This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients serhiy.storchaka, steven.daprano
Date 2017-05-20.14:31:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1495290714.4.0.632365827942.issue30413@psf.upfronthosting.co.za>
In-reply-to
Content
In general LGTM. I left few minor comments on Rietveld. Needed the versionadded directive, Misc/NEWS and What's New entries.

But shouldn't the new function have name "filterfalse" for parallel with itertools.filterfalse? And this would better match the style of the fnmatch module, fnmatchcase doesn't contain an underscore.

Tests for fnmatch.filter are too poor. I think we should add more tests (this is other issue).
History
Date User Action Args
2017-05-20 14:31:54serhiy.storchakasetrecipients: + serhiy.storchaka, steven.daprano
2017-05-20 14:31:54serhiy.storchakasetmessageid: <1495290714.4.0.632365827942.issue30413@psf.upfronthosting.co.za>
2017-05-20 14:31:54serhiy.storchakalinkissue30413 messages
2017-05-20 14:31:54serhiy.storchakacreate