Message293491
> Why do you think this isn't a good idea?
If the command fails, you simplify have no idea of what happened. For example, thanks to stdout/stderr, you noticed the warning. Without stdout/stderr, the warning should be hidden.
webbrowser is already able to detect that GNOME is running and uses gvfs-open in that case. Maybe we should exchange these two blocks of code to prefer gvfs-open over xdg-open on GNOME?
# use xdg-open if around
if shutil.which("xdg-open"):
register("xdg-open", None, BackgroundBrowser("xdg-open"))
# The default GNOME3 browser
if "GNOME_DESKTOP_SESSION_ID" in os.environ and shutil.which("gvfs-open"):
register("gvfs-open", None, BackgroundBrowser("gvfs-open"))
Do you get the warning if you use gvfs-open? |
|
Date |
User |
Action |
Args |
2017-05-11 11:49:00 | vstinner | set | recipients:
+ vstinner, serhiy.storchaka, desbma |
2017-05-11 11:49:00 | vstinner | set | messageid: <1494503340.16.0.174431676047.issue30219@psf.upfronthosting.co.za> |
2017-05-11 11:49:00 | vstinner | link | issue30219 messages |
2017-05-11 11:49:00 | vstinner | create | |
|