Message293459
> What is this pull request for?
I didn't notice so many PR without useful commit message (PR description). Not sure that it's useful.
> Include version updates if necessary.
I don't understand this part.
> Make sure you have signed the CLA agreement before continuing
We have a bot for that and the bot explains how to sign it, no?
> ### Reason to modify
I never saw such template in any other project. I'm not sure that we must require an exact format for new PR.
> ### Tests and reviews
> I have tested the code and it works.
While I run Linux and have Windows and FreeBSD VM, sometimes I'm lazy and rely on the CI. I consider that it's waste to burn CI CPUs sometimes :-) For example, it's not that easy to test a change specific to Windows on Python 2.7, but AppVeyor now runs tests for you!
--
@Jensen: I feel that you have useful hints for new contributors, but I suggest you to enhance the devguide instead of using a template. |
|
Date |
User |
Action |
Args |
2017-05-10 23:07:16 | vstinner | set | recipients:
+ vstinner, brett.cannon, Jensen Taylor |
2017-05-10 23:07:16 | vstinner | set | messageid: <1494457636.03.0.0944494698202.issue30336@psf.upfronthosting.co.za> |
2017-05-10 23:07:16 | vstinner | link | issue30336 messages |
2017-05-10 23:07:15 | vstinner | create | |
|