Author steven.daprano
Recipients jdufresne, steven.daprano
Date 2017-05-07.13:42:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Is this unnecessary code churn?

That's not a rhetorical question. Fixing code that isn't broken is not always a good idea.

``func(<list comprehension>)`` is not always identical to ``func(<generator expression>)``, there are situations where there is a significant performance difference between the two. E.g. str.join() is significantly faster when passed a list than when passed a generator expression. According to my tests:

    ''.join(['abc' for x in range(1000000)])

is about 40% faster than

    ''.join('abc' for x in range(1000000))
Date User Action Args
2017-05-07 13:42:56steven.dapranosetrecipients: + steven.daprano, jdufresne
2017-05-07 13:42:56steven.dapranosetmessageid: <>
2017-05-07 13:42:56steven.dapranolinkissue30296 messages
2017-05-07 13:42:56steven.dapranocreate