Author vstinner
Recipients pitrou, vstinner
Date 2017-05-04.21:07:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1493932073.94.0.460881586073.issue30273@psf.upfronthosting.co.za>
In-reply-to
Content
> get_config_var('AST_H_DIR')

Oh, I see. My commit a5c62a8e9f0de6c4133825a5710984a3cd5e102b removed multiple variables from Makefile.pre.in to simplify it, but I didn't notice that some of them (only AST_H_DIR?) were used outside Makefile.pre.in. I completely forgot the evil sysconfig (evil in term of backward compatibility...).

I removed the following variables from Makefile.pre.in:

* @GENERATED_COMMENT@
* ASDLGEN
* ASDLGEN_FILES
* AST_ASDL
* AST_C
* AST_C_DIR
* AST_H
* AST_H_DIR
* GRAMMAR_C
* GRAMMAR_H
* GRAMMAR_INPUT
* OPCODETARGETGEN
* OPCODETARGETGEN_FILES
* OPCODETARGETS_H
* OPCODE_H
* OPCODE_H_DIR
* OPCODE_H_GEN
* OPCODE_H_SCRIPT
* PYTHON_FOR_GEN (renamed to PYTHON_FOR_REGEN)

I didn't see the point of the AST_H_DIR variable since its value was hardcoded to "Include" and it was only used to regenerate generated files related to AST.

I don't understand why sysconfig chose this specific variable to get the "Include" subdirectory!?

I'm writing a fix to replace AST_H_DIR variable with "Include".
History
Date User Action Args
2017-05-04 21:07:53vstinnersetrecipients: + vstinner, pitrou
2017-05-04 21:07:53vstinnersetmessageid: <1493932073.94.0.460881586073.issue30273@psf.upfronthosting.co.za>
2017-05-04 21:07:53vstinnerlinkissue30273 messages
2017-05-04 21:07:53vstinnercreate