➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Clay Gerrard
Recipients Claudiu.Popa, Clay Gerrard, demian.brecht, vstinner
Date 2017-05-01.18:13:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1493662395.18.0.300511735362.issue21790@psf.upfronthosting.co.za>
In-reply-to
Content 
I don't think the default is bad/wrong so much as it's an inflexible magic number.

I think blocksize should be parameterized as an attribute on the connection - or at least a class attribute or module level constant so we can monkey patch it without having to create a subclass and redefine the *entire* send method (!?).

Not having a good string to pull at here is causing a non-trivial amount of pain:

https://github.com/sigmavirus24/requests-toolbelt/pull/84/files
https://github.com/sigmavirus24/requests-toolbelt/issues/75
https://webcache.googleusercontent.com/search?q=cache:WPSngjyUzg4J:https://technology.jana.com/2015/12/30/dont-use-python-httplib-or-any-library-that-uses-it-to-transfer-large-files-especially-to-china/+&cd=5&hl=en&ct=clnk&gl=us
https://bugs.launchpad.net/python-swiftclient/+bug/1671621
History
Date User Action Args
2017-05-01 18:13:15Clay Gerrardsetrecipients: + Clay Gerrard, vstinner, Claudiu.Popa, demian.brecht
2017-05-01 18:13:15Clay Gerrardsetmessageid: <1493662395.18.0.300511735362.issue21790@psf.upfronthosting.co.za>
2017-05-01 18:13:15Clay Gerrardlinkissue21790 messages
2017-05-01 18:13:14Clay Gerrardcreate