Author neologix
Recipients giampaolo.rodola, neologix, vstinner, yselivanov
Date 2017-04-29.09:24:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH_1eM1z7qrda-XiCPKBjqE2GJ2LvWgzCzE0TH=kaxEvM0n6kw@mail.gmail.com>
In-reply-to <1491676313.63.0.225447568651.issue30014@psf.upfronthosting.co.za>
Content
The rationale for rejecting wouldn't be "DRY does not apply in this
case", it would be that this makes the code more complicated, and that
a negligible speedup would not be worth it.
Now, thanks to your benchmark, a 10% speedup is not negligible, so
that seems like a reasonable change.
I'll have a look at your refactoring code, and once pushed, we can
optimize modify().
History
Date User Action Args
2017-04-29 09:24:18neologixsetrecipients: + neologix, vstinner, giampaolo.rodola, yselivanov
2017-04-29 09:24:18neologixlinkissue30014 messages
2017-04-29 09:24:18neologixcreate